Subject: PR/33623 CVS commit: [netbsd-3] src/sbin/ping
To: None <gnats-admin@netbsd.org, netbsd-bugs@netbsd.org, chuck@ece.cmu.edu>
From: Manuel Bouyer <bouyer@netbsd.org>
List: netbsd-bugs
Date: 08/26/2007 18:55:02
The following reply was made to PR bin/33623; it has been noted by GNATS.
From: Manuel Bouyer <bouyer@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: PR/33623 CVS commit: [netbsd-3] src/sbin/ping
Date: Sun, 26 Aug 2007 18:53:05 +0000 (UTC)
Module Name: src
Committed By: bouyer
Date: Sun Aug 26 18:53:05 UTC 2007
Modified Files:
src/sbin/ping [netbsd-3]: ping.c
Log Message:
Pull up following revision(s) (requested by ghen in ticket #1817):
sbin/ping/ping.c: revisions 1.79 - 1.80
PR/33623: Chuck Cranor: Ping stops when ran in the background
because it tries to set the tty not to print kerninfo. Change it
to only only play with the tty when ping is running in the foreground
(and will not stop when calling tcsetattr()). In my opinion, it is
preferable to print the kerninfo line with the ping info message
rather than to mess with the tty, but that's just me.
Factor out the tty code and explain we prefer to stop in the ^Z bg case
when we exit, rather than kill the tty setting.
To generate a diff of this commit:
cvs rdiff -r1.77 -r1.77.2.1 src/sbin/ping/ping.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.