Subject: Re: kern/36878: overflow in raidframe parity rebuild status
To: None <oster@NetBSD.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org,>
From: dieter roelants <dieter.NetBSD@pandora.be>
List: netbsd-bugs
Date: 09/05/2007 14:30:02
The following reply was made to PR kern/36878; it has been noted by GNATS.
From: dieter roelants <dieter.NetBSD@pandora.be>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: kern/36878: overflow in raidframe parity rebuild status
Date: Wed, 5 Sep 2007 16:29:00 +0200
On Mon, 3 Sep 2007 17:35:02 +0000 (UTC)
Greg Oster <oster@cs.usask.ca> wrote:
> I'm trying to figure out how this can happen.... all the variables
> in use should be 64-bit quantities.... I know there used to be some
> isuses with this, but I'm sure 4.0_BETA2 has those fixes in it...
Hmm, you're right about the reconstruction, it would probably give the
right result (again, I had only witnessed this with parity rebuilding).
However parity_rewrite_stripes_done, recon_stripes_done (but it seems
unused), and also copyback_stripes_done in struct RF_Raid_s all have
type int. Changing those to RF_StripeCount_t fixes the issue too.
Thanks and kind regards,
dieter