Subject: Re: PR/36560 CVS commit: src/lib/libcurses
To: None <install-manager@netbsd.org, gnats-admin@netbsd.org,>
From: David Laight <david@l8s.co.uk>
List: netbsd-bugs
Date: 11/08/2007 08:10:18
The following reply was made to PR install/36560; it has been noted by GNATS.

From: David Laight <david@l8s.co.uk>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/36560 CVS commit: src/lib/libcurses
Date: Thu, 8 Nov 2007 08:11:27 +0000

 On Thu, Nov 08, 2007 at 06:45:07AM +0000, Julian Coleman wrote:
 > The following reply was made to PR install/36560; it has been noted by GNATS.
 > 
 > From: Julian Coleman <jdc@netbsd.org>
 > To: gnats-bugs@NetBSD.org
 > Cc: 
 > Subject: PR/36560 CVS commit: src/lib/libcurses
 > Date: Thu,  8 Nov 2007 06:42:22 +0000 (UTC)
 > 
 >  Module Name:	src
 >  Committed By:	jdc
 >  Date:		Thu Nov  8 06:42:22 UTC 2007
 >  
 >  Modified Files:
 >  	src/lib/libcurses: addbytes.c
 >  
 >  Log Message:
 >  Fix the handling for added carriage return characters.
 >  
 >  Should fix the "staircase effect" part of PR 36560.
 
         case L'\r':
 -               win->curx = 0;
 +               *x = 0;
 		return OK;
 
 Doesn't look right to me.
 
 'x' is a cached value for 'win->curx' (which makes it all pointless
 passing the value into another function) so the caller is likely to
 expect that the cached value will be updated (as other parts of this
 function do) not the value itself.
 
 Does this work properly is the '\r' is followed be additional bytes ?
 
 
 	David
 
 -- 
 David Laight: david@l8s.co.uk