Subject: Re: PR/36560 CVS commit: src/lib/libcurses
To: None <install-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Julian Coleman <jdc@coris.org.uk>
List: netbsd-bugs
Date: 11/08/2007 10:15:24
The following reply was made to PR install/36560; it has been noted by GNATS.
From: Julian Coleman <jdc@coris.org.uk>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: PR/36560 CVS commit: src/lib/libcurses
Date: Thu, 8 Nov 2007 10:13:08 +0000
> Doesn't look right to me.
> Does this work properly is the '\r' is followed be additional bytes ?
Yes. Martin's test program has:
addstr("\r ---> ");
I think that updating win->cur[xy] in the _cursesi_addbyte() and
_cursesi_addwchar() functions won't work, because we have called the
SYNCH_IN macro before we call them and SYNCH_OUT afterward.
The change makes the '\r' handing in both _cursesi_addbyte() and
_cursesi_addwchar() consistent and appears to be correct to me (I'm
happy to be corrected here though!).
Thanks,
J
--
My other computer also runs NetBSD / Sailing at Newbiggin
http://www.netbsd.org/ / http://www.newbigginsailingclub.org/