Subject: Re: PR/36560 CVS commit: src/lib/libcurses
To: None <install-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Chavdar Ivanov <ci4ic4@gmail.com>
List: netbsd-bugs
Date: 11/10/2007 23:30:07
The following reply was made to PR install/36560; it has been noted by GNATS.

From: "Chavdar Ivanov" <ci4ic4@gmail.com>
To: gnats-bugs@netbsd.org
Cc: install-manager@netbsd.org, gnats-admin@netbsd.org,
	netbsd-bugs@netbsd.org
Subject: Re: PR/36560 CVS commit: src/lib/libcurses
Date: Sat, 10 Nov 2007 23:27:45 +0000

 On Nov 8, 2007 10:15 AM, Julian Coleman <jdc@coris.org.uk> wrote:
 > The following reply was made to PR install/36560; it has been noted by GNATS.
 >
 > From: Julian Coleman <jdc@coris.org.uk>
 > To: gnats-bugs@NetBSD.org
 > Cc:
 > Subject: Re: PR/36560 CVS commit: src/lib/libcurses
 > Date: Thu, 8 Nov 2007 10:13:08 +0000
 >
 >  > Doesn't look right to me.
 >
 >  > Does this work properly is the '\r' is followed be additional bytes ?
 >
 >  Yes.  Martin's test program has:
 
 I just finished i386 build.sh release and tested the installation ISO
 with the suggested patch. Seems fine now, thanks.
 
 >
 >    addstr("\r ---> ");
 >
 >  I think that updating win->cur[xy] in the _cursesi_addbyte() and
 >  _cursesi_addwchar() functions won't work, because we have called the
 >  SYNCH_IN macro before we call them and SYNCH_OUT afterward.
 >
 >  The change makes the '\r' handing in both _cursesi_addbyte() and
 >  _cursesi_addwchar() consistent and appears to be correct to me (I'm
 >  happy to be corrected here though!).
 >
 >  Thanks,
 >
 >  J
 >
 >  --
 >    My other computer also runs NetBSD    /        Sailing at Newbiggin
 >          http://www.netbsd.org/        /   http://www.newbigginsailingclub.org/
 >
 >
 
 
 
 -- 
 /dev/random says:
 	I can walk on water, but I stagger on alcohol.
 ----------------------------------------------------------------
 Chavdar Ivanov   | Talbot Way, Small Heath Business Park
 Delcam UK        | Birmingham B10 0HJ, United Kingdom
 Customer Support | (+44)121-6831014
 ----------------------------------------------------------------