Subject: PR/28134 CVS commit: src/sys/ufs/ffs
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: David A. Holland <dholland@netbsd.org>
List: netbsd-bugs
Date: 11/23/2007 18:00:09
The following reply was made to PR kern/28134; it has been noted by GNATS.
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: PR/28134 CVS commit: src/sys/ufs/ffs
Date: Fri, 23 Nov 2007 18:00:46 +0000 (UTC)
Module Name: src
Committed By: dholland
Date: Fri Nov 23 18:00:46 UTC 2007
Modified Files:
src/sys/ufs/ffs: fs.h
Log Message:
Change the fs_clean member of the ffs superblock to be unsigned
(uint8_t instead of int8_t) - this prevents an ugly sign-extension
printing bug as well as formally undefined behavior when you mount an
unclean fs enough times.
From (my own) PR kern/28134; I've been carrying this patch for three
years, long enough to forget about it, and it's had no ill effects in
that time.
reviewed: pooka
To generate a diff of this commit:
cvs rdiff -r1.47 -r1.48 src/sys/ufs/ffs/fs.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.