kern/37756: nfsmb(4) fails to attach nForce430 SMBus

[fukumoto%imasy.or.jp@localhost]

>Number:         37756
>Category:       kern
>Synopsis:       nfsmb(4) fails to attach nForce430 SMBus
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 14 20:25:00 +0000 2008
>Originator:     atsushi fukumoto
>Release:        NetBSD 4.99.49
>Organization:
>Environment:
        
        
System: NetBSD kestrel 4.99.49 NetBSD 4.99.49 (GENERIC) #14: Tue Jan 15 
05:02:27 JST 2008 
fukumoto@kestrel:/usr/src.current/sys/arch/i386/compile/obj/GENERIC i386
Architecture: i386
Machine: i386
>Description:
nfsmb(4) fails to attach nForce430 SMBus.

Jan 15 11:58:09 kestrel /netbsd: nfsmbc0 at pci0 dev 10 function 1: NVIDIA 
nForce430 SMBus Controller (rev. 0xa3)
Jan 15 11:58:09 kestrel /netbsd: nfsmb0 at nfsmbc0 SMBus 1
Jan 15 11:58:09 kestrel /netbsd: nfsmb0: failed to map SMBus space
Jan 15 11:58:09 kestrel /netbsd: nfsmb1 at nfsmbc0 SMBus 2
Jan 15 11:58:09 kestrel /netbsd: nfsmb1: failed to map SMBus space

sys/dev/pci/nfsmb.c:nfsmb_attach() switch statement chooses
nForce430 to use NFORCE_OLD_SMB*, which appears to be wrong.
After commenting out the case line, it looks like working correctly:

nfsmbc0 at pci0 dev 10 function 1: NVIDIA nForce430 SMBus Controller (rev. 0xa3)
nfsmb0 at nfsmbc0 SMBus 1
iic0 at nfsmb0: I2C bus
spdmem0 at iic0 addr 0x51
spdmem0: DDR2 SDRAM memory, no parity or ECC, 1024MB, 667MHz, PC2-5300
spdmem0: 14 rows, 10 cols, 2 ranks, 4 banks/chip, 3.00ns cycle time
spdmem0: voltage SSTL 1.8V, refresh time 7.8us (self-refreshing)
nfsmb1 at nfsmbc0 SMBus 2
iic1 at nfsmb1: I2C bus

>How-To-Repeat:
        
>Fix:
        
Index: nfsmb.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/nfsmb.c,v
retrieving revision 1.10
diff -u -u -r1.10 nfsmb.c
--- nfsmb.c     4 Dec 2007 15:58:11 -0000       1.10
+++ nfsmb.c     14 Jan 2008 20:16:00 -0000
@@ -158,7 +158,6 @@
        case PCI_PRODUCT_NVIDIA_NFORCE3_SMBUS:
        case PCI_PRODUCT_NVIDIA_NFORCE3_250_SMBUS:
        case PCI_PRODUCT_NVIDIA_NFORCE4_SMBUS:
-       case PCI_PRODUCT_NVIDIA_NFORCE430_SMBUS:
                baseregs[0] = NFORCE_OLD_SMB1;
                baseregs[1] = NFORCE_OLD_SMB2;
                break;

>Unformatted: