kern/37843: nttcp doesn't work

[yamt%mwd.biglobe.ne.jp@localhost]

>Number:         37843
>Category:       kern
>Synopsis:       nttcp doesn't work
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jan 22 11:20:00 +0000 2008
>Originator:     YAMAMOTO Takashi <yamt%mwd.biglobe.ne.jp@localhost>
>Release:        NetBSD 4.99.49
>Organization:
        
>Environment:
>Description:
        pkgsrc/benchmarks/nttcp doesn't work.

        nttcp try to do setsockopt SO_LINGER with:

struct linger Ling = {
        1,              /* option on */
        1000000         /* linger time, for our control connection */
};

        after uipc_socket.c rev.1.131, we rejects values larger
        than USHRT_MAX.
----------------------------
revision 1.131
date: 2006/12/08 00:23:08;  author: christos;  state: Exp;  lines: +6 -5
- make so_linger unsigned short to double the range
- return 1 or 0 for the flag being set instead of the flag value
- check for range properly
----------------------------

        another report of the failure:
        http://mail-index.netbsd.org/netbsd-help/2007/03/09/0002.html

        (note that nttcp's error handling is somehow broken and
        can corrupt errno before reporting it.)
>How-To-Repeat:
        run nttcp.
>Fix:
        while nttcp is broken and should be fixed, i guess it could be better
        for us to truncate this big value silently, given that it's likely
        intended to be "forever".