toolchain/37896: nbmtree segmentation violation in build.sh

[germainl%pseudointeractive.com@localhost]

>Number:         37896
>Category:       toolchain
>Synopsis:       nbmtree segmentation violation in build.sh
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jan 29 09:40:00 +0000 2008
>Originator:     germain le chapelain
>Release:        netbsd  cvs
>Organization:
>Environment:
>Description:
nbmtree segfault while building netbsd amd64 cvs on freebsd amd64

===
Creating /usr/home/german/work/netbsd/src/obj/destdir.amd64/etc/mtree/set.base
Creating /usr/home/german/work/netbsd/src/obj/destdir.amd64/etc/mtree/set.comp
Creating /usr/home/german/work/netbsd/src/obj/destdir.amd64/etc/mtree/set.etc
Creating /usr/home/german/work/netbsd/src/obj/destdir.amd64/etc/mtree/set.games
Creating /usr/home/german/work/netbsd/src/obj/destdir.amd64/etc/mtree/set.man
Creating /usr/home/german/work/netbsd/src/obj/destdir.amd64/etc/mtree/set.misc
Creating /usr/home/german/work/netbsd/src/obj/destdir.amd64/etc/mtree/set.tests
Creating /usr/home/german/work/netbsd/src/obj/destdir.amd64/etc/mtree/set.text
postinstall-fix-obsolete ===> .
   === Removing obsolete files ===
/bin/sh /usr/home/german/work/netbsd/src/usr.sbin/postinstall/postinstall -s 
/usr/home/german/work/netbsd/src -d 
/usr/home/german/work/netbsd/src/obj/destdir.amd64/ fix obsolete
Source directory: /usr/home/german/work/netbsd/src
Target directory: /usr/home/german/work/netbsd/src/obj/destdir.amd64/
obsolete fix:
postinstall fixes passed: obsolete
postinstall fixes failed:
   ===============================
checkflist ===> distrib/sets
( cat /usr/home/german/work/netbsd/src/etc/mtree/NetBSD.dist ;  echo '/unset 
all' ;  cat /usr/home/german/work/netbsd/src/obj/destdir.amd64/METALOG )  | 
/usr/home/german/work/netbsd/src/tooldir.FreeBSD-7.0-PRERELEASE-amd64/bin/nbmtree
 -C -k all -N /usr/home/german/work/netbsd/src/etc > 
/usr/home/german/work/netbsd/src/obj/destdir.amd64/METALOG.new &&  ( rm -f 
/usr/home/german/work/netbsd/src/obj/destdir.amd64/METALOG ;  mv 
/usr/home/german/work/netbsd/src/obj/destdir.amd64/METALOG.new 
/usr/home/german/work/netbsd/src/obj/destdir.amd64/METALOG )
Segmentation fault (core dumped)

*** Failed target:  
/usr/home/german/work/netbsd/src/obj/destdir.amd64/METALOG.sanitised
*** Failed command: ( cat 
/usr/home/german/work/netbsd/src/etc/mtree/NetBSD.dist ; echo '/unset all' ; 
cat /usr/home/german/work/netbsd/src/obj/destdir.amd64/METALOG ) | 
/usr/home/german/work/netbsd/src/tooldir.FreeBSD-7.0-PRERELEASE-amd64/bin/nbmtree
 -C -k all -N /usr/home/german/work/netbsd/src/etc > 
/usr/home/german/work/netbsd/src/obj/destdir.amd64/METALOG.new && ( rm -f 
/usr/home/german/work/netbsd/src/obj/destdir.amd64/METALOG ; mv 
/usr/home/german/work/netbsd/src/obj/destdir.amd64/METALOG.new 
/usr/home/german/work/netbsd/src/obj/destdir.amd64/METALOG )
*** Error code 139

Stop.
nbmake: stopped in /usr/home/german/work/netbsd/src/distrib/sets

===

when digging into it, the pointer returned by a call to group_from_gid(...) was 
garbage.
>How-To-Repeat:

>Fix:
adding the few line to have the call to user/group name from the nbcompat 
system fixed my problem, maybe there is something wrong here ?

[german@germ /usr/home/german/work/netbsd/src/usr.sbin/mtree]$ diff -u 
.#spec.c.1.64 spec.c
--- .#spec.c.1.64       2008-01-28 23:17:29.000000000 +0000
+++ spec.c      2008-01-28 23:14:15.000000000 +0000
@@ -1,9 +1,4 @@
 /*     $NetBSD: spec.c,v 1.64 2006/12/14 20:09:36 he Exp $     */
-#if HAVE_NBTOOL_CONFIG_H
-/* XXX Now, re-apply the renaming that we undid above. */
-#define        group_from_gid  __nbcompat_group_from_gid
-#define        user_from_uid   __nbcompat_user_from_uid
-#endif