bin/38175: comsat misunderstands NetBSD 4.0 ptyfs PTY names

[eravin%panix.com@localhost]

>Number:         38175
>Category:       bin
>Synopsis:       comsat misunderstands NetBSD 4.0 ptyfs PTY names
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 05 15:40:02 +0000 2008
>Originator:     Ed Ravin
>Release:        4.0
>Organization:
Public Access Networks Corp
>Environment:
NetBSD panix5.panix.com 4.0 NetBSD 4.0 (PANIX-XEN3U-USER) #0: Thu Feb 28 
22:13:03 EST 2008  
root%juggler.panix.com@localhost:/misc2/obj/misc2/devel/netbsd/4.0/src/sys/arch/i386/compile/PANIX-XEN3U-USER
 i386
>Description:
comsat no longer works on our NetBSD 4.0 system.

We get these messages in syslog instead of successful notifications:

Mar  5 08:40:39 logsources@panix5/166.84.1.5 comsat[12662]: '/' in "/dev/pts/51"

I believe this is the code at fault in comsat.c:

    248     if (strncmp(cr, "pts/", 4) == 0)
    249         cr += 4;
    250     if (strchr(cr, '/')) {
    251         /* A slash is an attempt to break security... */
    252         syslog(LOG_AUTH | LOG_NOTICE, "Unexpected `/' in `%s'",
    253             ep->line);
    254         return;
    255     }

>How-To-Repeat:
use comsat with a user logged into a ptyfs-style pty like /dev/pts/44
>Fix: