install/38329: /usr/src/usr.bin/printf/printf.c -Wall errors on int error != void error() (it refs bltin.h)

[ggm%pobox.com@localhost]

>Number:         38329
>Category:       install
>Synopsis:       /usr/src/usr.bin/printf/printf.c -Wall errors on int error != 
>void error() (it refs bltin.h)
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    install-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 29 10:25:00 +0000 2008
>Originator:     George Michaelson
>Release:        current
>Organization:
>Environment:
build.sh run on a host at NetBSD  4.99.45 NetBSD 4.99.45 (GENERIC) #1: Wed Dec 
26 13:17:49 GMT 2007  
ggm@:/var/tmp/build/obj/usr/src/sys/arch/i386/compile/GENERIC i386

>Description:
NetBSD  4.99.45 NetBSD 4.99.45 (GENERIC) #1: Wed Dec 26 13:17:49 GMT 2007  
ggm@:/var/tmp/build/obj/usr/src/sys/arch/i386/compile/GENERIC i386

cannot run build.sh to completion.

it dies with:

#   compile  sh/printf.o
/usr/src/../tools/bin/i386--netbsdelf-gcc -O2  -Wall -Wstrict-prototypes 
-Wmissing-pro
totypes -Wpointer-arith -Wno-sign-compare -Wno-traditional -Wreturn-type 
-Wswitch -Wsh
adow -Wcast-qual -Wwrite-strings -Wextra -Wno-unused-parameter -std=gnu99  
-Werror   -
DSHELL -I. -I/usr/src/bin/sh -nostdinc -isystem 
/usr/src/../obj/destdir.i386/usr/inclu
de   -c    /usr/src/usr.bin/printf/printf.c
cc1: warnings being treated as errors
/usr/src/usr.bin/printf/printf.c: In function 'printfcmd':
/usr/src/usr.bin/printf/printf.c:132: warning: declaration of 'error' shadows a 
global
 declaration
/usr/src/usr.bin/printf/../../bin/sh/bltin/bltin.h:87: warning: shadowed 
declaration i
s here
/usr/src/usr.bin/printf/printf.c:214: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:214: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:214: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:214: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:254: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:254: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:254: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:254: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:261: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:261: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:261: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:261: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:270: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:270: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:270: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:270: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:281: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:281: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:281: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:281: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:292: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:292: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:292: error: void value not ignored as it ought 
to be
/usr/src/usr.bin/printf/printf.c:292: error: void value not ignored as it ought 
to be

*** Failed target:  printf.o
*** Failed command: /usr/src/../tools/bin/i386--netbsdelf-gcc -O2 -Wall 
-Wstrict-proto
types -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wno-traditional 
-Wreturn
-type -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wextra 
-Wno-unused-parameter -std
=gnu99 -Werror -DSHELL -I. -I/usr/src/bin/sh -nostdinc -isystem 
/usr/src/../obj/destdi
r.i386/usr/include -c /usr/src/usr.bin/printf/printf.c
*** Failed command: /usr/src/../tools/bin/i386--netbsdelf-gcc -O2 -Wall 
-Wstrict-proto
types -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wno-traditional 
-Wreturn
-type -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wextra 
-Wno-unused-parameter -std
=gnu99 -Werror -DSHELL -I. -I/usr/src/bin/sh -nostdinc -isystem 
/usr/src/../obj/destdi
r.i386/usr/include -c /usr/src/usr.bin/printf/printf.c
*** Error code 1

Stop.
nbmake: stopped in /usr/src/bin/sh

>How-To-Repeat:
not sure if this is because of the vintage of the current I am on, but I don't 
believe so: I removed obj/tools before running build.sh

>Fix: