Re: kern/38375: LOCKDEBUG panic with 4.99.58 SMP kernels

[Andrew Doran <ad%netbsd.org@localhost>]

The following reply was made to PR kern/38375; it has been noted by GNATS.

From: Andrew Doran <ad%netbsd.org@localhost>
To: Takeshi Nakayama <tn%catvmics.ne.jp@localhost>
Cc: gnats-bugs%NetBSD.org@localhost, he%NetBSD.org@localhost
Subject: Re: kern/38375: LOCKDEBUG panic with 4.99.58 SMP kernels
Date: Thu, 10 Apr 2008 00:55:47 +0100

 On Thu, Apr 10, 2008 at 12:36:21AM +0900, Takeshi Nakayama wrote:
 
 > I found a suspicious unlock in startlwp by code inspection of
 > sparc64 MD.
 > 
 > Is it safe to remove?
 
 Yes, I'm suprised it's still there.
 
 Thanks,
 Andrew
  
 > Index: syscall.c
 > ===================================================================
 > RCS file: /cvsroot/src/sys/arch/sparc64/sparc64/syscall.c,v
 > retrieving revision 1.27
 > diff -u -d -p -r1.27 syscall.c
 > --- syscall.c        7 Apr 2008 14:18:11 -0000       1.27
 > +++ syscall.c        9 Apr 2008 15:25:03 -0000
 > @@ -505,6 +505,5 @@ startlwp(void *arg)
 >  #endif
 >      pool_put(&lwp_uc_pool, uc);
 >  
 > -    KERNEL_UNLOCK_LAST(l);
 >      userret(l, 0, 0);
 >  }
 > 
 > -- Takeshi Nakayama