Re: kern/38937: aprint_debug calls make no sense during shutdown

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR kern/38937; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/38937: aprint_debug calls make no sense during shutdown
Date: Sun, 15 Jun 2008 02:43:59 +0200

 --DocE+STaALJfprDB
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 I talked to joerg, and here is a patch that models his suggested solution for
 i386 (we would need to modify all cpu_reboot if we go this way)
 
 Martin
 
 
 --DocE+STaALJfprDB
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=patch
 
 Index: sys/reboot.h
 ===================================================================
 RCS file: /cvsroot/src/sys/sys/reboot.h,v
 retrieving revision 1.25
 diff -c -u -r1.25 reboot.h
 --- sys/reboot.h       25 Dec 2007 18:33:48 -0000      1.25
 +++ sys/reboot.h       15 Jun 2008 00:37:37 -0000
 @@ -64,6 +64,8 @@
  #define       AB_SILENT       0x00040000      /* boot silently */
  #define       AB_DEBUG        0x00080000      /* boot with debug messages */
  
 +#define AB_VERBOSITY_MASK     (AB_QUIET|AB_VERBOSE|AB_SILENT|AB_DEBUG)
 +
  /*
   * The top 4 bits are architecture specific and are used to
   * pass information between the bootblocks and the machine
 Index: arch/i386/i386/machdep.c
 ===================================================================
 RCS file: /cvsroot/src/sys/arch/i386/i386/machdep.c,v
 retrieving revision 1.636
 diff -c -u -r1.636 machdep.c
 --- arch/i386/i386/machdep.c   5 Jun 2008 21:44:31 -0000       1.636
 +++ arch/i386/i386/machdep.c   15 Jun 2008 00:37:37 -0000
 @@ -872,7 +872,10 @@
                goto haltsys;
        }
  
 -      boothowto = howto;
 +      /* verbosity flags persist */
 +      boothowto = (howto & ~AB_VERBOSITY_MASK)
 +          | (boothowto & AB_VERBOSITY_MASK);
 +
        if ((howto & RB_NOSYNC) == 0 && waittime < 0) {
                waittime = 0;
                vfs_shutdown();
 
 --DocE+STaALJfprDB--