PR/35131 CVS commit: src

["David A. Holland" <dholland%netbsd.org@localhost>]

The following reply was made to PR bin/35131; it has been noted by GNATS.

From: "David A. Holland" <dholland%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/35131 CVS commit: src
Date: Sun, 13 Jul 2008 20:07:49 +0000 (UTC)

 Module Name:   src
 Committed By:  dholland
 Date:          Sun Jul 13 20:07:49 UTC 2008
 
 Modified Files:
        src/games/dm: dm.c
        src/libexec/comsat: comsat.c
        src/usr.bin/systat: vmstat.c
        src/usr.bin/users: users.c
        src/usr.bin/who: utmpentry.c utmpentry.h
        src/usr.sbin/rwhod: rwhod.c
        src/usr.sbin/syslogd: syslogd.c
 
 Log Message:
 Clarify how one is supposed to use the pointers returned by getutentries()
 (the utmpentry.c code), specifically with respect to who owns them and
 when to free them. Now they're owned by utmpentry.c, only. Abolish the
 freeutentries() function, which was the wrong abstraction; add instead
 endutentries(), which flushes out the internally managed memory.
 
 Update callers as necessary. Some (e.g. talkd) had been leaking memory;
 others (e.g. syslogd) had been accidentally freeing and reloading utmp
 more often than necessary. There are a couple untidy bits in users and
 rwhod that someone should look after sometime, maybe.
 
 Fixes PR bin/35131, which was about talkd's memory leak.
 
 
 To generate a diff of this commit:
 cvs rdiff -r1.24 -r1.25 src/games/dm/dm.c
 cvs rdiff -r1.36 -r1.37 src/libexec/comsat/comsat.c
 cvs rdiff -r1.70 -r1.71 src/usr.bin/systat/vmstat.c
 cvs rdiff -r1.13 -r1.14 src/usr.bin/users/users.c
 cvs rdiff -r1.14 -r1.15 src/usr.bin/who/utmpentry.c
 cvs rdiff -r1.6 -r1.7 src/usr.bin/who/utmpentry.h
 cvs rdiff -r1.35 -r1.36 src/usr.sbin/rwhod/rwhod.c
 cvs rdiff -r1.84 -r1.85 src/usr.sbin/syslogd/syslogd.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.