Re: lib/39215: getdevmajor()/major() types don't match

[David Holland <dholland%eecs.harvard.edu@localhost>]

On Thu, Jul 31, 2008 at 06:50:01PM +0000, Matthias Drochner wrote:
 >  dholland%eecs.harvard.edu@localhost said:
 >  > Probably changing major() (and minor(), for symmetry) to produce an
 >  > unsigned value
 >  
 >  The kernel is using int for majors and minors, and is using -1
 >  as special value. I'd say we should adjust getdevmajor() - it
 >  is NetBSD specific and used at only one place in the tree.
 >  (and the error check against ~0 is ugly)

Ah, I figured it was too late for that. That's definitely preferable

 >  I've just done a full build with the appended patch - would that
 >  work for you?

Yes, looks fine, thanks.

-- 
   - David A. Holland / dholland%eecs.harvard.edu@localhost