Re: lib/39215: getdevmajor()/major() types don't match

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR lib/39215; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: M.Drochner%fz-juelich.de@localhost, gnats-bugs%NetBSD.org@localhost
Cc: lib-bug-people%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost, 
        netbsd-bugs%NetBSD.org@localhost
Subject: Re: lib/39215: getdevmajor()/major() types don't match
Date: Thu, 31 Jul 2008 17:19:58 -0400

 On Jul 31,  8:46pm, M.Drochner%fz-juelich.de@localhost (Matthias Drochner) 
wrote:
 -- Subject: Re: lib/39215: getdevmajor()/major() types don't match
 
 | dholland%eecs.harvard.edu@localhost said:
 | > Probably changing major() (and minor(), for symmetry) to produce an
 | > unsigned value
 | 
 | The kernel is using int for majors and minors, and is using -1
 | as special value. I'd say we should adjust getdevmajor() - it
 | is NetBSD specific and used at only one place in the tree.
 | (and the error check against ~0 is ugly)
 | I've just done a full build with the appended patch - would that
 | work for you?
 | 
 | best regards
 | Matthias
 
 Don't change dev_t back to int please. dev_t in the christos_time_t branch
 is uint64_t!
 
 christos