NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/39266: NetBSD/amd64 doesn't build with -Wextra
The following reply was made to PR kern/39266; it has been noted by GNATS.
From: "Jared D. McNeill" <jmcneill%invisible.ca@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/39266: NetBSD/amd64 doesn't build with -Wextra
Date: Fri, 01 Aug 2008 14:52:27 -0400
xtraeme%gmail.com@localhost wrote:
> Index: compat/linux/arch/amd64/linux_machdep.c
> ===================================================================
> RCS file: /cvsroot/src/sys/compat/linux/arch/amd64/linux_machdep.c,v
> retrieving revision 1.30
> diff -b -u -p -r1.30 linux_machdep.c
> --- compat/linux/arch/amd64/linux_machdep.c 11 May 2008 17:13:43 -0000
> 1.30
> +++ compat/linux/arch/amd64/linux_machdep.c 1 Aug 2008 17:45:16 -0000
> @@ -473,10 +473,10 @@ linux_sys_rt_sigreturn(struct lwp *l, co
> * And the stack
> */
> uctx.uc_stack.ss_flags = 0;
> - if (luctx->luc_stack.ss_flags & LINUX_SS_ONSTACK);
> + if (luctx->luc_stack.ss_flags & LINUX_SS_ONSTACK)
> uctx.uc_stack.ss_flags = SS_ONSTACK;
>
> - if (luctx->luc_stack.ss_flags & LINUX_SS_DISABLE);
> + if (luctx->luc_stack.ss_flags & LINUX_SS_DISABLE)
> uctx.uc_stack.ss_flags = SS_DISABLE;
>
> uctx.uc_stack.ss_sp = luctx->luc_stack.ss_sp;
A modified version of the above has been checked in. You need to |= the
native stack ss_flags as well.
Cheers,
Jared
Home |
Main Index |
Thread Index |
Old Index