NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

toolchain/39360: missing "-" in build.sh breaks "do we already have a toolchain" check



>Number:         39360
>Category:       toolchain
>Synopsis:       missing "-" in build.sh breaks "do we already have a 
>toolchain" check
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Aug 15 20:50:00 +0000 2008
>Originator:     Andrew Cagney
>Release:        current
>Organization:
>Environment:
f9
>Description:
The code checking for a pre-build tools uses a different path to that creating 
it, leading to the tools being re-built (or at least configured) on each 
build.sh run.

The patch below shows where the "-" is missing.

Index: build.sh
===================================================================
RCS file: /cvsroot/src/build.sh,v
retrieving revision 1.189
diff -p -r1.189 build.sh
*** build.sh    27 Jun 2008 21:38:36 -0000      1.189
--- build.sh    14 Aug 2008 22:10:33 -0000
*************** try_set_TOOLDIR()
*** 894,903 ****
        [ -n "${makeobjdir}" ] && topobjdir="${topobjdir}/${makeobjdir}"
        local host_ostype="${uname_s}-$(
                echo "${uname_r}" | sed -e 's/([^)]*)//g' -e 's/ /_/g'
!               )$(
                echo "${uname_p}" | sed -e 's/([^)]*)//g' -e 's/ /_/g'
                )"
        local guess_TOOLDIR="${topobjdir}/tooldir.${host_ostype}"
  
        # Look for a suitable ${toolprefix}make, nbmake, bmake, or make.
        guess_make="${guess_TOOLDIR}/bin/${toolprefix}make"
--- 894,904 ----
        [ -n "${makeobjdir}" ] && topobjdir="${topobjdir}/${makeobjdir}"
        local host_ostype="${uname_s}-$(
                echo "${uname_r}" | sed -e 's/([^)]*)//g' -e 's/ /_/g'
!               )-$(
                echo "${uname_p}" | sed -e 's/([^)]*)//g' -e 's/ /_/g'
                )"
        local guess_TOOLDIR="${topobjdir}/tooldir.${host_ostype}"
+ echo guess_TOOLDIR=${guess_TOOLDIR} 1>&2
  
        # Look for a suitable ${toolprefix}make, nbmake, bmake, or make.
        guess_make="${guess_TOOLDIR}/bin/${toolprefix}make"

>How-To-Repeat:

>Fix:



Home | Main Index | Thread Index | Old Index