PR/40043 CVS commit: src/usr.sbin/syslogd

[Christos Zoulas <christos%netbsd.org@localhost>]

The following reply was made to PR bin/40043; it has been noted by GNATS.

From: Christos Zoulas <christos%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/40043 CVS commit: src/usr.sbin/syslogd
Date: Thu, 27 Nov 2008 20:37:21 +0000 (UTC)

 Module Name:   src
 Committed By:  christos
 Date:          Thu Nov 27 20:37:21 UTC 2008
 
 Modified Files:
        src/usr.sbin/syslogd: syslogd.c
 
 Log Message:
 PR/40043: Geoff C. Wing: syslogd timestamping and protocol parsing deficiencies
 Syslogd does not properly handle:
 
 1) the ADDDATE flag which is set with -T invocation and when messages
    come from the kernel.  Other cases where it is set it is ignored
    as timestamping is always done (e.g. logmsg_async())
 
 2) the variable found_ts in check_timestamp().  It would determine
    whether or not the message had a (possibly valid) timestamp, set
    found_ts to true, then ignore that in most cases.  If we can't find
    a timestamp return.
 
 3) messages without a parsable timestamp should get one when outputting
    the BSD syslog format so that a syslog-protocol timestamp isn't
    injected (chopped off with BSD syslog length) giving something like:
     "2008-11-27T15:0 cisco -: 1790:"
      ^ time might have been 2008-11-27T15:02:35.296497+11:00
 
 4) syslog protocol version checking only checked for a leading numeral
    one (1) then skipped two places (presuming a space).  Messages sent
    from some sources (e.g. my cisco) may be
      "1795: Nov 27 04:12:52: %LINEPROTO-5-..."
    which would be chopped to
        "95: Nov 27 04:12:52: %LINEPROTO-5-..."
 
 
 To generate a diff of this commit:
 cvs rdiff -r1.93 -r1.94 src/usr.sbin/syslogd/syslogd.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.