Re: kern/40384 (64 bit time_t broke wscons)

[yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)]

The following reply was made to PR kern/40384; it has been noted by GNATS.

From: yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)
To: christos%zoulas.com@localhost
Cc: gnats-bugs%NetBSD.org@localhost, kern-bug-people%netbsd.org@localhost, 
netbsd-bugs%netbsd.org@localhost,
        gnats-admin%netbsd.org@localhost
Subject: Re: kern/40384 (64 bit time_t broke wscons)
Date: Thu, 15 Jan 2009 01:05:29 +0900 (JST)

 > On Jan 14, 11:57pm, yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi) 
 > wrote:
 > -- Subject: Re: kern/40384 (64 bit time_t broke wscons)
 > 
 > | it flushes the queue, yes.  but it seems unsafe to me.
 > | eg. if malloc() sleeps.
 > | eg. if someone is in the middle of wsevent_read().
 > | necessary locking complicates the code more, i guess.
 > 
 > Got it. Fixed.
 > 
 > Thanks,
 > 
 > christos
 
 well, have you checked whether it's safe even if every EVSIZE()
 returns different values due to concurrent setversions?
 
 with the way i suggested, only uiomove in wsevent_read and
 _INJECT ioctl needs conversion, right?  would it be so complicate?
 
 YAMAMOTO Takashi