kern/41179: Incorrect return values from AcpiOsExecute()

[Jukka Ruohonen <jruohonen%iki.fi@localhost>]

>Number:         41179
>Category:       kern
>Synopsis:       Incorrect return values from AcpiOsExecute()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 10 03:40:00 +0000 2009
>Originator:     Jukka Ruohonen
>Release:        NetBSD 5.99.8
>Organization:
-
>Environment:
NetBSD 5.99.8
>Description:

This goes to the trivia-section; as we have an API, we may as well follow it
(see below).

>How-To-Repeat:
        -
>Fix:

Index: acpi.c
===================================================================
RCS file: /cvsroot/src/sys/dev/acpi/acpi.c,v
retrieving revision 1.123
diff -u -p -r1.123 acpi.c
--- acpi.c      30 Jan 2009 12:51:03 -0000      1.123
+++ acpi.c      4 Apr 2009 12:33:15 -0000
@@ -972,7 +972,7 @@
 acpi_fixed_button_handler(void *context)
 {
        struct sysmon_pswitch *smpsw = context;
-       int rv;
+       ACPI_STATUS rv;
 
 #ifdef ACPI_BUT_DEBUG
        printf("%s: fixed button handler\n", smpsw->smpsw_name);

Index: acpi_acad.c
===================================================================
RCS file: /cvsroot/src/sys/dev/acpi/acpi_acad.c,v
retrieving revision 1.33
diff -u -p -r1.33 acpi_acad.c
--- acpi_acad.c 23 Mar 2008 18:38:57 -0000      1.33
+++ acpi_acad.c 4 Apr 2009 12:23:57 -0000
@@ -239,7 +239,7 @@ acpiacad_notify_handler(ACPI_HANDLE hand
 {
        device_t dv = context;
        struct acpiacad_softc *sc = device_private(dv);
-       int rv;
+       ACPI_STATUS rv;
 
        switch (notify) {
        /*

Index: acpi_bat.c
===================================================================
RCS file: /cvsroot/src/sys/dev/acpi/acpi_bat.c,v
retrieving revision 1.69
diff -u -p -r1.69 acpi_bat.c
--- acpi_bat.c  3 Jun 2008 15:02:31 -0000       1.69
+++ acpi_bat.c  4 Apr 2009 12:35:11 -0000
@@ -667,7 +667,7 @@ static void
 acpibat_notify_handler(ACPI_HANDLE handle, UINT32 notify, void *context)
 {
        device_t dv = context;
-       int rv;
+       ACPI_STATUS rv;
 
 #ifdef ACPI_BAT_DEBUG
        aprint_debug_dev(dv, "received notify message: 0x%x\n", notify);

Index: acpi_button.c
===================================================================
RCS file: /cvsroot/src/sys/dev/acpi/acpi_button.c,v
retrieving revision 1.25
diff -u -p -r1.25 acpi_button.c
--- acpi_button.c       9 Dec 2007 20:27:52 -0000       1.25
+++ acpi_button.c       4 Apr 2009 12:36:16 -0000
@@ -182,7 +182,7 @@ static void
 acpibut_notify_handler(ACPI_HANDLE handle, UINT32 notify, void *context)
 {
        device_t dv = context;
-       int rv;
+       ACPI_STATUS rv;
 
        switch (notify) {
        case ACPI_NOTIFY_S0PowerButtonPressed:

Index: acpi_lid.c
===================================================================
RCS file: /cvsroot/src/sys/dev/acpi/acpi_lid.c,v
retrieving revision 1.26
diff -u -p -r1.26 acpi_lid.c
--- acpi_lid.c  15 Jul 2008 16:19:37 -0000      1.26
+++ acpi_lid.c  4 Apr 2009 12:37:05 -0000
@@ -206,7 +206,7 @@ acpilid_notify_handler(ACPI_HANDLE handl
 {
        device_t dv = context;
        struct acpilid_softc *sc = device_private(dv);
-       int rv;
+       ACPI_STATUS rv;
 
        switch (notify) {
        case ACPI_NOTIFY_LidStatusChanged:

Index: acpi_tz.c
===================================================================
RCS file: /cvsroot/src/sys/dev/acpi/acpi_tz.c,v
retrieving revision 1.39
diff -u -p -r1.39 acpi_tz.c
--- acpi_tz.c   9 Nov 2008 13:54:06 -0000       1.39
+++ acpi_tz.c   9 Apr 2009 14:05:03 -0000
@@ -512,7 +512,7 @@ acpitz_notify_handler(ACPI_HANDLE hdl, U
        device_t dv = opaque;
        ACPI_OSD_EXEC_CALLBACK func = NULL;
        const char *name;
-       int rv;
+       ACPI_STATUS rv;
 
        switch (notify) {
        case ACPI_NOTIFY_ThermalZoneStatusChanged:
@@ -533,7 +533,7 @@ acpitz_notify_handler(ACPI_HANDLE hdl, U
        KASSERT(func != NULL);
 
        rv = AcpiOsExecute(OSL_NOTIFY_HANDLER, func, dv);
-       if (rv != AE_OK)
+       if (ACPI_FAILURE(rv))
                aprint_debug_dev(dv, "unable to queue %s\n", name);
 }