Re: xsrc/40322

[Rafal Boni <rafal%pobox.com@localhost>]

The following reply was made to PR xsrc/40322; it has been noted by GNATS.

From: Rafal Boni <rafal%pobox.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: xsrc/40322
Date: Thu, 16 Apr 2009 23:17:53 -0400

 At least for the r128 driver, the problem is that the driver is built without
 VGAHW support, so it doesn't appear to do any VGA-state restoration.  To see
 if you are having the same problem, look for the following message in your
 Xorg log:
 
        VGAHW support not compiled, VGA module load skipped
 
 The following patch makes it build with VGAHW support -- that build restores
 the console state on VT switch just fine on my i386 / r128 test machine I
 had the initial trouble with (see earlier comments and the now-closed-as-dup
 xsrc/40606).  Ignore the commented out CPPFLAGS; that requires more work to
 get a correct config.h generated for the r128 driver, which for the purposes
 of getting this fixed is largely un-necessary even if it might be the better
 fix.
 
 I suspect other drivers have the same issue, but haven't audited which ones
 depend on WITH_VGAHW and don't define it in Makefiles / get it via one of
 xorg-config.h / xorg-server.h
 
 --rafal
 
 ---8<------8<------8<------8<------8<------8<------8<------8<------8<---
 diff --git a/external/mit/xorg/server/drivers/xf86-video-r128/Makefile 
b/external/mit/xorg/server/drivers/xf86-video-r128/Makefile
 index 2105d57..d6bf27c 100644
 --- a/external/mit/xorg/server/drivers/xf86-video-r128/Makefile
 +++ b/external/mit/xorg/server/drivers/xf86-video-r128/Makefile
 @@ -8,4 +8,7 @@ SRCS=  r128_accel.c r128_cursor.c r128_dga.c r128_driver.c \
  
  MAN=  r128.4
  
 +#CPPFLAGS+=   -DHAVE_CONFIG_H -I${X11SRCDIR.${DRIVER}}/../include
 +CPPFLAGS+=    -DWITH_VGAHW
 +
  .include "../Makefile.xf86-driver"
 ---8<------8<------8<------8<------8<------8<------8<------8<------8<---
 
 -- 
   Time is an illusion; lunchtime, doubly so.     |/\/\|           Rafal Boni
                    -- Ford Prefect               |\/\/|      
rafal%pobox.com@localhost