Re: bin/42381: LD_ADD.$name does not work as expected

[Alan Barrett <apb%cequrux.com@localhost>]

The following reply was made to PR bin/42381; it has been noted by GNATS.

From: Alan Barrett <apb%cequrux.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: bin/42381: LD_ADD.$name does not work as expected
Date: Thu, 26 Nov 2009 12:33:50 +0000

 Most of the bsd.*.mk files are written with the assumption that
 each program will be built from a separate source directory.
 However, src/tests/kernel/Makefile attempts to build several programs
 from the same source directory.  That ends up in trouble when line
 268 of bsd.prog.mk does this:
 
 LDADD+=     ${LDADD.${_P}}
 
 which it will repeat once for each program.  The intent is to append
 LDADD.t_rnd to LDADD while building the t_rnd program, but the
 effect is to append LDADD.t_rnd to LDADD while building other
 programs in the src/tests/kernel directory.
 
 bsd.prog.mk also does this:
 
 _LDADD.${_P}=           ${LDADD}    ${LDADD.${_P}}
 
 and I believe that the fix would be to remove the "LDADD+=${LDADD.${_P}}"
 and rewrite relevant rules in terms of ${_LDADD.${_P}} (note the
 underline) instead of ${LDADD}.  Similarly for several other variables in
 bsd.prog.mk.
 
 --apb (Alan Barrett)