bin/44077: redundant xdr_passwd implementation should be removed from source tree

[Wolfgang.Stukenbrock%nagler-company.com@localhost]

>Number:         44077
>Category:       bin
>Synopsis:       redundant xdr_passwd implementation should be removed from 
>source tree
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Nov 10 08:55:00 +0000 2010
>Originator:     Dr. Wolfgang Stukenbrock
>Release:        NetBSD 5.0.2
>Organization:
Dr. Nagler & Company GmbH
        
>Environment:
        
        
System: NetBSD test-s1 5.0.2 NetBSD 5.0.2 (NSW-S011) #11: Mon Nov 8 16:38:16 
CET 2010 
wgstuken@s012:/export/NetBSD-5.0.2/N+C-build/.OBJDIR_amd64/export/NetBSD-5.0.2/src/sys/arch/amd64/compile/NSW-S011
 amd64
Architecture: x86_64
Machine: amd64
>Description:
        There two source implementations for the same routines in 
/usr/src/lib/librcpsvc and /usr/src/usr.sbin/rpc.yppasswdd.
        In order to avoid code replication, the version in 
/usr/src/usr.sbin/rpc.yppasswdd should be eliminated and
        the version from /usr/src/lib/librcpsvc should be used for the 
yppasswdd too.
        At the moment, yppasswdd has no dynamic reference to 
/usr/lib/librpcsvc.so, but it uses two other shared libs.
        So there are two way to pull in the required routines:
         - staticaly link in /usr/lib/librpcsvc.a so only this source file gets 
retrieved from it
         - reference a third shared lib /usr/lib/librpcsvc.so.???
        From my point of view it makes no real difference, because yppasswdd 
already uses shared libs.
        The maintainer should select one of the two methods.

>How-To-Repeat:
        not relevant
>Fix:
        remove /usr/src/usr.sbin/rpc.yppasswdd/yppasswdd_xdr.c and link (either 
static or dynamic) librpcsvc instead.
        For dynamic linking add
DPADD+= ${LIBRPCSVC}
LDADD+= -lrpcsvc
        to the makefile (as done in /usr/src/usr.bin/passwd/Makefile) and 
remove yppasswdd_xdr.c from SRCS.
        I do not know the correct way for linking librpcsvc statically, so no 
fix description here - sorry.

>Unformatted: