NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: lib/44074 (libnetpgp: fix the autodetection of armoured messages)



Synopsis: libnetpgp: fix the autodetection of armoured messages

Responsible-Changed-From-To: lib-bug-people->agc
Responsible-Changed-By: agc%NetBSD.org@localhost
Responsible-Changed-When: Mon, 15 Nov 2010 08:31:44 +0000
Responsible-Changed-Why:
netpgp is my baby


State-Changed-From-To: open->feedback
State-Changed-By: agc%NetBSD.org@localhost
State-Changed-When: Mon, 15 Nov 2010 08:31:44 +0000
State-Changed-Why:
I took a different approach and used a regular expression to
match the various ASCII-encoded headers that might be read.

Hopefully, this is more scalable than testing individual
patterns. I didn't bother with the line-ending matching,
since I don't think they're relevant - the alternative to the
ASCII headers is a PGP packet, which looks way different.

I've put the state to feedback since I didn't do as much
testing as I'd have liked to, so if you tell me if this fixes
it, I'd be very grateful.

Finally, thanks for sending this PR - clearsigning has not
been a priority in netpgp up until now, and you are giving it
a great try-out. Thanks!





Home | Main Index | Thread Index | Old Index