Re: xsrc/44159: startx fails w/ recent xsrc changes in -current

[bch%methodlogic.net@localhost]

On Sat, Nov 27, 2010 at 10:35:01AM +0000, matthew green wrote:
> The following reply was made to PR xsrc/44159; it has been noted by GNATS.
> 
> From: matthew green <mrg%eterna.com.au@localhost>
> To: gnats-bugs%NetBSD.org@localhost
> Cc: xsrc-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
>     netbsd-bugs%netbsd.org@localhost
> Subject: re: xsrc/44159: startx fails w/ recent xsrc changes in -current
> Date: Sat, 27 Nov 2010 21:31:15 +1100
> 
>  this one is likely a problem with the csu _init() calls in to libpixman
>  leaving the $rsp unaligned for amd64.  the patch i have based on an idea
>  from joerg is below.  you'll need to rebuild and install lib/csu and
>  then rebuild and install libpixman itself to fix this problem.


The file below was updated to r1.2 with latest cvs update, but that
only re-introduced the problem it was supposed to fix (or at least
conincidentally, the problem is back).


>  .mrg.
>  
>  
>  Index: arch/x86_64/crtbegin.S
>  ===================================================================
>  RCS file: /cvsroot/src/lib/csu/arch/x86_64/crtbegin.S,v
>  retrieving revision 1.1
>  diff -p -r1.1 crtbegin.S
>  *** arch/x86_64/crtbegin.S   7 Aug 2010 18:01:34 -0000       1.1
>  --- arch/x86_64/crtbegin.S   27 Nov 2010 10:27:08 -0000
>  *************** __do_global_dtors_aux:
>  *** 94,99 ****
>  --- 94,100 ----
>    #endif
>    
>       pushq   %rbx
>  +    pushq   %rbx
>       leaq    8+__DTOR_LIST__(%rip), %rbx
>    3:
>       movq    (%rbx), %rax
>  *************** __do_global_dtors_aux:
>  *** 104,109 ****
>  --- 105,111 ----
>       jmp     3b      
>    4:
>       popq    %rbx
>  +    popq    %rbx
>    
>       cmpq    $0, __deregister_frame_info@GOTPCREL(%rip)
>       je      5f
>  *************** __do_global_ctors_aux:
>  *** 137,142 ****
>  --- 139,145 ----
>    3:
>    
>       pushq   %rbx
>  +    pushq   %rbx
>       leaq    -8+__CTOR_LIST_END__(%rip), %rbx
>    4:
>       movq    (%rbx), %rax
>  *************** __do_global_ctors_aux:
>  *** 148,153 ****
>  --- 151,157 ----
>    
>    5:
>       popq    %rbx
>  +    popq    %rbx
>    
>       ret
>    
>  

-- 
Brad Harder
Method Logic Digital Consulting
http://methodlogic.net
http://twitter.com/bcharder