Re: PR/44523 CVS commit: src/sys/fs/hfs

[Taylor R Campbell <campbell+netbsd%mumble.net@localhost>]

   Date: Thu, 10 Feb 2011 01:50:05 +0000 (UTC)
   From: "Christos Zoulas" <christos%netbsd.org@localhost>

   PR/44523: Taylor R Campbell: mount_hfs badly handles file names with slashes
   in them, encode them as colons. XXX: Should encode : as :: too?

No, I don't think that's worth the trouble: as far as I know, the
on-disk format is not supposed to have colons in file names, whereas
it is supposed to be able to have slashes in file names, because the
old Macintosh pathname syntax used colons rather than slashes as
separators.

   +            /* XXX: perhaps check for colons too, and encode them? */
   +            for (ni = 0; ni < len; ni++)
   +                    if (unicn[ni] == (unichar_t)'/')
   +                            unicn[ni] = (unichar_t)':';

Oops -- I got this backwards in the patch I submitted.  (I must have
tweaked the patch after testing it and before sending it.)  This
fragment in hfs_vop_lookup should replace colon by slash, not the
other way around.