Re: misc/45038: lack of tests options

[Nicolas Joly <njoly%pasteur.fr@localhost>]

The following reply was made to PR misc/45038; it has been noted by GNATS.

From: Nicolas Joly <njoly%pasteur.fr@localhost>
To: Julio Merino <jmmv%NetBSD.org@localhost>
Cc: Nicolas Joly <njoly%pasteur.fr@localhost>, gnats-bugs%NetBSD.org@localhost,
        misc-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
        netbsd-bugs%netbsd.org@localhost, yamt%NetBSD.org@localhost
Subject: Re: misc/45038: lack of tests options
Date: Thu, 16 Jun 2011 23:24:26 +0200

 --vkogqOf2sHV7VnPd
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 On Thu, Jun 16, 2011 at 05:12:52PM +0200, Nicolas Joly wrote:
 > On Thu, Jun 16, 2011 at 04:01:12PM +0100, Julio M. Merino Vidal wrote:
 > > On 6/16/11 3:52 PM, Nicolas Joly wrote:
 > > > On Thu, Jun 16, 2011 at 02:44:21PM +0100, Julio M. Merino Vidal wrote:
 > > >>
 > > >> Also document the unprivileged_user option.  It's used explicitly by
 > > >> some tests.  (It defaults to _atf.)
 > > > 
 > > > I don't find it anywhere. Is it "require.user" = "unprivileged" ? 
 > > 
 > > Ah sorry, it's unprivileged-user.
 > 
 > Got it.
 > 
 > > > IMHO, we should only document in tests(7) the configuration variables
 > > > which are not part of ATF.
 > > 
 > > Well, I guess this one is a bit of a compromise.  unprivileged-user
 > > was _not_ an atf-specific variable; it used to be defined by NetBSD
 > > only.  These days, it has a special meaning in atf itself, but some
 > > NetBSD tests query it directly to do their own stuff.  In other
 > > words, it is not only used by require.user=unprivileged, but also to
 > > perform some specific actions in the tmpfs tests.
 > 
 > I'll have a look, and add it.
 
 Julio,
 
 Is the `unprivileged-user' option description correct ?
 
 Thanks.
 
 -- 
 Nicolas Joly
 
 Projects and Developments in Bioinformatics
 Institut Pasteur, Paris.
 
 --vkogqOf2sHV7VnPd
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="netbsd-testsman.diff"
 
 Index: share/man/man7/tests.7
 ===================================================================
 RCS file: /cvsroot/src/share/man/man7/tests.7,v
 retrieving revision 1.4
 diff -u -p -r1.4 tests.7
 --- share/man/man7/tests.7     7 Nov 2010 17:49:33 -0000       1.4
 +++ share/man/man7/tests.7     16 Jun 2011 21:08:04 -0000
 @@ -25,7 +25,7 @@
  .\" OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN
  .\" IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  .\"
 -.Dd November 7, 2010
 +.Dd June 16, 2011
  .Dt TESTS 7
  .Os
  .Sh NAME
 @@ -163,6 +163,20 @@ The suite-specific configuration file im
  which contains properties shared among all test suites.
  These files conform to the configuration file format described in
  .Xr atf-formats 5 .
 +.Pp
 +The following configuration variables are available in the
 +.Nx
 +test suite :
 +.Bl -tag -width "unprivileged-user"
 +.It fstype
 +When set to a filesystem type, restrict tests programs from the
 +.Pa /usr/tests/fs/vfs/
 +tree to only run test cases for the given type.
 +.It unprivileged-user
 +This variable allows setting an unprivileged user login name to be used by
 +tests. Default to
 +.Sq _atf .
 +.El
  .Ss What to do if something fails?
  If there is
  .Em any failure
 
 --vkogqOf2sHV7VnPd--