Re: PR/45618 CVS commit: src/sys/kern

[Motoyuki OHMORI <ohmori%chikushi-u.ac.jp@localhost>]

Dear Christos,

# This is just reply because GNAT requests me to reply to close the ticket.

Thank you very much for your quick response.  Now, the problem has been solved.
Please close the ticket.

BTW, I am curious about one trivial thing of your patch if there is a case
where computed ticks can be negative.  I thought that `kn_sdata' is unsigned
and computed ticks would be unsigned.  I then thought that `tticks == 0' was
enough.

Anyway, thank you very much for your fix.  I think that now our kernel gets
stronger and more stable against an unresonable timeout interval from user land.

Best regards,
--
Motoyuki OHMORI <ohmori%chikushi-u.ac.jp@localhost>

On Thu, Nov 17, 2011 at 01:35:02 +0000, Christos Zoulas wrote:
> The following reply was made to PR kern/45618; it has been noted by GNATS.
> 
> From: "Christos Zoulas" <christos%netbsd.org@localhost>
> To: gnats-bugs%gnats.NetBSD.org@localhost
> Cc: 
> Subject: PR/45618 CVS commit: src/sys/kern
> Date: Wed, 16 Nov 2011 20:19:37 -0500
> 
>  Module Name: src
>  Committed By:        christos
>  Date:                Thu Nov 17 01:19:37 UTC 2011
>  
>  Modified Files:
>       src/sys/kern: kern_event.c
>  
>  Log Message:
>  PR/45618: Motoyuki OHMORI: kqueue EVFILT_TIMER with smaller timeout value
>  makes DIAGNOSTIC kernel panic:
>       KASSERT((c->c_flags & CALLOUT_PENDING) != 0);
>  If the computed ticks are <= 0 set it to 1
>  
>  
>  To generate a diff of this commit:
>  cvs rdiff -u -r1.72 -r1.73 src/sys/kern/kern_event.c
>  
>  Please note that diffs are not public domain; they are subject to the
>  copyright notices on the relevant files.
>