lib/45989: lint does not use -w on anything != i386 for libc

[martin%NetBSD.org@localhost]

>Number:         45989
>Category:       lib
>Synopsis:       libc lint invocation does include -w only on i386
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 12 01:30:01 +0000 2012
>Originator:     Martin Husemann
>Release:        NetBSD 5.99.60
>Organization:
The NetBSD Foundation, Inc.
>Environment:
System: NetBSD night-owl.duskware.de 5.99.60 NetBSD 5.99.60 (NIGHT-OWL) #50: 
Sat Jan 28 11:49:36 CET 2012 
martin%night-owl.duskware.de@localhost:/usr/src/sys/arch/amd64/compile/NIGHT-OWL
 amd64
Architecture: x86_64
Machine: amd64
>Description:

The src/lib/libc/Makefile.inc has the following gem:

.if ${MACHINE_ARCH} == "i386"
# Set lint to exit on warnings
LINTFLAGS+=     -w
.endif

Since most people do not develop on i386 machines any more, this may lead
to missed warnings from lint that later break the build post commit (like
recently with the posix_spawn addition).

We should aim for libc being lintclean on all archs, but as a stopgap, at
least amd64 should be added to the list.

>How-To-Repeat:
code inspection (or watch the autmatic test environment catch you breaking
the build).

>Fix:
Remove the .if, fix the fallout.