Re: bin/46015: atf rquotad test no longer runnable

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

The following reply was made to PR bin/46015; it has been noted by GNATS.

From: Manuel Bouyer <bouyer%antioche.eu.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: gnats-admin%NetBSD.org@localhost, netbsd-bugs%NetBSD.org@localhost, 
dholland%NetBSD.org@localhost
Subject: Re: bin/46015: atf rquotad test no longer runnable
Date: Mon, 13 Feb 2012 16:24:11 +0100

 On Mon, Feb 13, 2012 at 09:35:02AM +0000, Martin Husemann wrote:
 > The following reply was made to PR bin/46015; it has been noted by GNATS.
 > 
 > From: Martin Husemann <martin%duskware.de@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc: 
 > Subject: Re: bin/46015: atf rquotad test no longer runnable
 > Date: Mon, 13 Feb 2012 10:33:34 +0100
 > 
 >  On Mon, Feb 13, 2012 at 06:35:00AM +0000, dholland%NetBSD.org@localhost 
 > wrote:
 >  > With the absolute latest HEAD, the rquota test now does this:
 >  > 
 >  > test_case_root: not found
 >  
 >  I don't quite understand the make magic involved, but certainly does not
 >  look like an atf fault to me:
 >  
 >  .for name in t_rquotad
 >  TESTS_SH+=      ${name}
 >  TESTS_SH_SRC_${name}=   ../ffs/quotas_common.sh ${name}.sh
 >  .endfor
 >  
 >  and ../ffs/quotas_common.sh defines the test_case_root function. Seems
 >  to work for the ../ffs shell based tests, which use it pretty much the
 >  same way.
 
 It's probably my fault; I forgot to update this test case when I split
 non-quota parts out of ../ffs/quotas_common.sh. This should probably be:
 TESTS_SH_SRC_${name}=  ../ffs/ffs_common.sh ../ffs/quotas_common.sh ${name}.sh
 
 I'll look at fixing this this evening, unless someone beats me.
 
 -- 
 Manuel Bouyer <bouyer%antioche.eu.org@localhost>
      NetBSD: 26 ans d'experience feront toujours la difference
 --