Re: install/38571: sysinst runs "postinstall fix"

[Alan Barrett <apb%cequrux.com@localhost>]

The following reply was made to PR install/38571; it has been noted by GNATS.

From: Alan Barrett <apb%cequrux.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: install/38571: sysinst runs "postinstall fix"
Date: Wed, 29 Feb 2012 13:35:03 +0200

 On Wed, 29 Feb 2012, Julian Djamil Fagir wrote:
 >  the attached patch fixes that issue for me.
 
 Thsnk you for working on this.
 
 >  On the one hand, it introduces a
 >  new function that exits curses, executes a command and afterwards returns.
 >  This function is used to execute etcupdate(8) in case the user wants it.
 
 That's fine in principle.  I haven't checked the implementation.
 
 >  +           runpostinstall = run_program(RUN_DISPLAY | RUN_CHROOT | 
 > RUN_ERROR_OK
 >  +                           | RUN_PROGRESS,
 >  +                           "/usr/sbin/postinstall -s /.sysinst -d / 
 > check");
 >  +           if (runpostinstall == 1) {
 
 If run_program returns the program's exit status, then any non-zero
 value means that something needs to be fixed.
 
 >  +                   process_menu(MENU_runpostinst, &runpostinstall);
 >  +                   /* runpostinstall:
 >  +                    * 0: postinstall fix
 >  +                    * 1: etcupdate
 >  +                    * 2: continue
 >  +                    * 3: abandon installation
 >  +                    */
 
 Will the output from postinstall still be visible when the user 
 has to choose a menu option?
 
 Also, I think we could have "re-run postinstall check" and "run 
 a shell to fix problems manually" as additional options in thie 
 menu, and loop here until the user is happy.  (Maybe they want to 
 run postinstall check, fix something in a shell, postinstall check 
 again, etcupdate, postinstall check again, fix something else in a 
 shell, ...)
 
 I usually want to run "postinstall fix SOME_KEYWORDS" and not
 "postinstall fix OTHER_KEYWORDS".  With enough work, we could
 dynamically build a menu using a list of keywords parsed from the
 output of "postinstall check", and descriptions parsed from the
 output of "postinstall list".
 
 --apb (Alan Barrett)