Re: bin/46142: The cpio(1), pax(1) and tar(1) manpages need improvement

[Thomas Klausner <wiz%NetBSD.org@localhost>]

The following reply was made to PR bin/46142; it has been noted by GNATS.

From: Thomas Klausner <wiz%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: bin/46142: The cpio(1), pax(1) and tar(1) manpages need
 improvement
Date: Sun, 4 Mar 2012 16:03:04 +0100

 On Sun, Mar 04, 2012 at 02:55:00PM +0000, Bug Hunting wrote:
 > The new, correct, default tape device is taken from src/include/paths.h
 > (`PATH_DEFTAPE'); altering the compiled-in tape devices should be
 > reviewed though, as it is not completely clear to me whether or
 > not this can or should simply be done.
 
 I've no idea about this part.
 
 > Index: bin/pax/cpio.1
 > ===================================================================
 > RCS file: /cvsroot/src/bin/pax/cpio.1,v
 > retrieving revision 1.13
 > diff -u -r1.13 cpio.1
 > --- bin/pax/cpio.1   19 Jun 2011 07:34:24 -0000      1.13
 > +++ bin/pax/cpio.1   4 Mar 2012 14:27:42 -0000
 > @@ -120,7 +120,7 @@
 >  Be verbose about operations.
 >  List filenames as they are written to the archive.
 >  .It Fl Fl xz
 > -Compress/decompress archive using
 > +Compress archive using
 >  .Xr xz 1
 >  format.
 >  .It Fl Z
 > @@ -128,7 +128,7 @@
 >  .Xr compress 1
 >  format.
 >  .It Fl z
 > -Compress/decompress archive using
 > +Compress archive using
 >  .Xr gzip 1
 >  format.
 >  .El
 
 Compare these two above to:
 > -Use
 > -.Xr bzip2 1
 > -for compression of the archive.
 > +Compress/decompress the archive using
 > +.Xr bzip2 1 .
 ..
 >  .It Fl Fl xz
 > -Compress/decompress archive using 
 > -.Xr xz  1 .
 > +Compress/decompress the archive using
 > +.Xr xz 1 .
 >  .It Fl z , Fl Fl gzip , Fl Fl gunzip
 > -Compress/decompress archive using
 > +Compress/decompress the archive using
 >  .Xr gzip 1 .
 ...
 >  .It Fl Z , Fl Fl compress , Fl Fl uncompress
 > -Compress archive using compress.
 > +Compress/decompress the archive using
 > +.Xr compress 1 .
 ...
 >  .It Fl Fl use-compress-program Ar program
 > -Use the named program as the program to decompress the input.
 > +Compress/decompress the archive using the named program.
 
 I think we should have consistency in the wording here.
 
 
 > +Exit as soon as each specified
 > +.Ar file
 > +argument has been matched.
 
 I'd prefer:
 Exit as soon as all specified
 .Ar file
 arguments have been matched.
 
 > Index: bin/pax/tar.c
 > ===================================================================
 > RCS file: /cvsroot/src/bin/pax/tar.c,v
 > retrieving revision 1.68
 > diff -u -r1.68 tar.c
 > --- bin/pax/tar.c    3 Nov 2011 21:59:45 -0000       1.68
 > +++ bin/pax/tar.c    4 Mar 2012 14:27:43 -0000
 > @@ -100,12 +100,12 @@
 >  static const char LONG_LINK[] = "././@LongLink";
 >  
 >  #ifdef _PAX_
 > -char DEV_0[] = "/dev/rst0";
 > -char DEV_1[] = "/dev/rst1";
 > -char DEV_4[] = "/dev/rst4";
 > -char DEV_5[] = "/dev/rst5";
 > -char DEV_7[] = "/dev/rst7";
 > -char DEV_8[] = "/dev/rst8";
 > +char DEV_0[] = "/dev/nrst0";
 > +char DEV_1[] = "/dev/nrst1";
 > +char DEV_4[] = "/dev/nrst4";
 > +char DEV_5[] = "/dev/nrst5";
 > +char DEV_7[] = "/dev/nrst7";
 > +char DEV_8[] = "/dev/nrst8";
 >  #endif
 >  
 >  static int
 
 Can someone please confirm if this patch is ok?
  Thomas