Re: kern/46221: Kernel panic in NFS server code

[Matthias Scheler <tron%zhadum.org.uk@localhost>]

The following reply was made to PR kern/46221; it has been noted by GNATS.

From: Matthias Scheler <tron%zhadum.org.uk@localhost>
To: "J. Hannken-Illjes" <hannken%eis.cs.tu-bs.de@localhost>
Cc: NetBSD GNATS <gnats-bugs%NetBSD.org@localhost>
Subject: Re: kern/46221: Kernel panic in NFS server code
Date: Wed, 21 Mar 2012 16:27:55 +0000

 On Wed, Mar 21, 2012 at 04:13:03PM +0100, J. Hannken-Illjes wrote:
 > Please add an vprint() call so we get more details for this vnode.
 
 Done. The patch now looks like this:
 
 Index: sys/ufs/ufs/ufs_vfsops.c
 ===================================================================
 RCS file: /cvsroot/src/sys/ufs/ufs/ufs_vfsops.c,v
 retrieving revision 1.50
 diff -u -r1.50 ufs_vfsops.c
 --- sys/ufs/ufs/ufs_vfsops.c   1 Feb 2012 05:34:43 -0000       1.50
 +++ sys/ufs/ufs/ufs_vfsops.c   21 Mar 2012 16:25:47 -0000
 @@ -223,7 +223,9 @@
                return (error);
        }
        ip = VTOI(nvp);
 -      if (ip->i_mode == 0 || ip->i_gen != ufhp->ufid_gen) {
 +      if (ip == NULL || ip->i_mode == 0 || ip->i_gen != ufhp->ufid_gen) {
 +              if (ip == NULL)
 +                      vprint("ufs_fhtovp: ip == NULL on vp %p\n", nvp);
                vput(nvp);
                *vpp = NULLVP;
                return (ESTALE);
 
 [Hmm, the "on vp %p" stuff is bogus but won't hurt.]
 
        Kind regards
 
 -- 
 Matthias Scheler                                  http://zhadum.org.uk/