Re: kern/46696: uhub disables port where USB keyboard attached

[Nick Hudson <skrll%netbsd.org@localhost>]

The following reply was made to PR kern/46696; it has been noted by GNATS.

From: Nick Hudson <skrll%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: kato%wide.ad.jp@localhost, kern-bug-people%netbsd.org@localhost, 
gnats-admin%netbsd.org@localhost, 
 netbsd-bugs%netbsd.org@localhost, mishka%NetBSD.org@localhost
Subject: Re: kern/46696: uhub disables port where USB keyboard attached
Date: Tue, 19 Mar 2013 08:37:25 +0000

 This is a multi-part message in MIME format.
 --------------010405020704010007000106
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Does this patch against -current fix the problem?
 
 Thanks,
 Nick
 
 --------------010405020704010007000106
 Content-Type: text/plain; charset=us-ascii;
  name="usb_subr.c.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="usb_subr.c.diff"
 
 Index: sys/dev/usb/usb_subr.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/usb/usb_subr.c,v
 retrieving revision 1.189
 diff -u -p -u -r1.189 usb_subr.c
 --- sys/dev/usb/usb_subr.c     22 Jan 2013 14:01:19 -0000      1.189
 +++ sys/dev/usb/usb_subr.c     19 Mar 2013 08:03:03 -0000
 @@ -1133,7 +1133,12 @@ usbd_new_device(device_t parent, usbd_bu
         * (which uses 64 bytes so it shouldn't be less),
         * highspeed devices must support 64 byte packets anyway
         */
 -      USETW(dev->def_ep_desc.wMaxPacketSize, 64);
 +
 +      if (speed == USB_SPEED_HIGH || speed == USB_SPEED_FULL)
 +              USETW(dev->def_ep_desc.wMaxPacketSize, 64);
 +      else
 +              USETW(dev->def_ep_desc.wMaxPacketSize, USB_MAX_IPACKET);
 +      
        dev->def_ep_desc.bInterval = 0;
  
        /* doesn't matter, just don't let it uninitialized */
 
 --------------010405020704010007000106--