Re: misc/47827: [PATCH] improve portability of NetBSD libc testcases

[Garrett Cooper <yaneurabeya%gmail.com@localhost>]

On May 17, 2013, at 1:05 PM, Garrett Cooper wrote:

> The following reply was made to PR misc/47827; it has been noted by GNATS.
> 
> From: Garrett Cooper <yaneurabeya%gmail.com@localhost>
> To: gnats-bugs%NetBSD.org@localhost
> Cc: 
> Subject: Re: misc/47827: [PATCH] improve portability of NetBSD libc testcases
> Date: Fri, 17 May 2013 13:01:22 -0400
> 
> --Apple-Mail=_0E583C49-25B9-45D5-B267-BB90A76B8167
> Content-Transfer-Encoding: 7bit
> Content-Type: text/plain;
>       charset=us-ascii
> 
>       Here's the initial patch.
> Thanks!
> -Garrett
> 
> 
> --Apple-Mail=_0E583C49-25B9-45D5-B267-BB90A76B8167
> Content-Disposition: attachment;
>       filename=netbsd-libc-test-portability-fixes.patch
> Content-Type: application/octet-stream;
>       name="netbsd-libc-test-portability-fixes.patch"
> Content-Transfer-Encoding: 7bit
> 
> Index: tests/lib/libc/Makefile.inc
> ===================================================================
> RCS file: /cvsroot/src/tests/lib/libc/Makefile.inc,v
> retrieving revision 1.1
> diff -u -r1.1 Makefile.inc
> --- tests/lib/libc/Makefile.inc       3 Nov 2010 16:10:21 -0000       1.1
> +++ tests/lib/libc/Makefile.inc       17 May 2013 16:00:42 -0000
> @@ -1 +1,3 @@
> +CFLAGS+=     -I${.CURDIR:H:H}
> +

        I forgot that NetBSD has a more sane (and correct) way of representing 
this:

CFLAGS+=        -I${NETBSDSRCDIR}/tests

        The above form works for me because I can't go more than two levels 
deep in the libc tests directory I've imported because of missing build changes 
in FreeBSD that I'm not willing/able to fix quite yet as our copy of 
bsd.progs.mk doesn't support directory traversal and specifying PROG*/SCRIPTS* 
out of the box.
Cheers!
-Garrett