re: kern/48233: IPMI hack for HP microserver with remote access card

[matthew green <mrg%eterna.com.au@localhost>]

The following reply was made to PR kern/48233; it has been noted by GNATS.

From: matthew green <mrg%eterna.com.au@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
    netbsd-bugs%netbsd.org@localhost
Subject: re: kern/48233: IPMI hack for HP microserver with remote access card
Date: Tue, 24 Sep 2013 11:21:21 +1000

 thanks for looking at this.  i've been considering one of these boxes
 for my own purposes..
 
 > +#if defined(HPMICROSERVER_IPMI)
 > +    ia->iaa_if_iospacing = 1;
 > +    ia->iaa_if_iobase = pipmi->smipmi_base_address - 7;
 > +    ia->iaa_if_iotype = 'i';
 > +    return;
 > +#endif
 
 hmmm.  since we know what machines this is a problem on can we replace
 this #ifdef with something that compares it to the data that acpi/bios
 gave us about the platform?  i'm not sure how this works on PCs, but
 eg, something like
 
        if (strcmp(hw_model, "HP Microserver n54L") == 0) {
                ia->iaa_if_iospacing = 1;
                ia->iaa_if_iobase = pipmi->smipmi_base_address - 7;
                ia->iaa_if_iotype = 'i';
                return;
        }
 
 i'm pretty sure this info can be reliably obtained on the HP systems.
 
 thanks!
 
 
 .mrg.