Re: toolchain/46182

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR misc/46182; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: toolchain/46182
Date: Sun, 6 Oct 2013 12:12:50 +0000

 On Tue, Mar 27, 2012 at 09:10:07PM +0000, Martin Husemann wrote:
  >  This probably is caused by src/distrib/sets/makesrctars which does a sed
  >  run on an mtree specification to make sure all simple files get 0664
  >  permissions:
  >  
  >     ${SED} -e 's:type=file:& mode=0664:' \
  >             -e 's:type=dir:& mode=0775:' \
  >  
  >  A few lines below it special cases build.sh and adds exec permissions.
  >  
  >  Now there are two ways to solve this:
  >  
  >   - add more exceptions to the script, so it creats executable scripts where
  >     needed
  >  
  >   - make sure the whole build does not need to invoke any shell script as
  >     direct command (but use "sh $script" instaed)
 
 Wouldn't it be better to fix the script to preserve execute
 permissions on regular files?
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost