xsrc/48380: xterm doesn't support 256 colors

[aniou%smutek.pl@localhost]

>Number:         48380
>Category:       xsrc
>Synopsis:       xterm doesn't support 256 colors
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    xsrc-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Nov 16 11:20:00 +0000 2013
>Originator:     Piotr Meyer
>Release:        6.1.2_PATCH
>Organization:
>Environment:
NetBSD turkan.smutek.pl 6.1.2_PATCH NetBSD 6.1.2_PATCH (GENERIC) amd64
>Description:
Recently I discovered that xterm in NetBSD 6.1.2 and 6.99.x is built without 
support for 256 colors. Using extra colors is rather widespread in modern 
configurations, thus lack of them in default install is annoying.
>How-To-Repeat:
Run - for example - script 
https://github.com/jpalardy/dotfiles/blob/master/bin/xterm-colortest.pl and see 
nothing special (we want fancy, rainbow colors).

You can also dig into binary, for example in NetBSD this test shows, what color 
identifies xterm know:

strings /usr/X11R7/bin/xterm | grep -E '^color[0-9]'|wc -l 
      16

...and in Ubuntu:

strings /usr/bin/xterm | grep -E '^color[0-9]'|wc -l 
256


>Fix:
Define in proper place (maybe in 
http://cvsweb.netbsd.org/bsdweb.cgi/xsrc/external/mit/xterm/include/xtermcfg.h 
?) flag: OPT_256_COLORS, at this moment this flag is undefined:

/* #undef OPT_256_COLORS */             /* CF_ARG_ENABLE(256-color) */