Re: lib/48821: libedit EL_SETTY doesn't work

[christos%zoulas.com@localhost (Christos Zoulas)]

On May 19,  4:25am, yasuoka%iij.ad.jp@localhost (yasuoka%iij.ad.jp@localhost) 
wrote:
-- Subject: lib/48821: libedit EL_SETTY doesn't work

| >Number:         48821
| >Category:       lib
| >Synopsis:       libedit EL_SETTY doesn't work
| >Confidential:   no
| >Severity:       non-critical
| >Priority:       medium
| >Responsible:    lib-bug-people
| >State:          open
| >Class:          sw-bug
| >Submitter-Id:   net
| >Arrival-Date:   Mon May 19 04:25:00 +0000 2014
| >Originator:     yasuoka%iij.ad.jp@localhost
| >Release:        NetBSD 5.1.2
| >Organization:
| Internet Initiative Japan
| >Environment:
| System: NetBSD yasuoka-nb.tokyo.iiji.jp 5.1.2 NetBSD 5.1.2 (GENERIC) #0: Thu 
Feb 2 12:12:28 UTC 2012 
builds%b7.netbsd.org@localhost:/home/builds/ab/netbsd-5-1-2-RELEASE/amd64/201202021012Z-obj/home/bui
| lds/ab/netbsd-5-1-2-RELEASE/src/sys/arch/amd64/compile/GENERIC amd64
| Architecture: x86_64
| Machine: amd64
| >Description:
| 
| As the man page of editline(3) and editrc(5), the parameter "EL_SETTY"
| can configure the terminal setting.  By using this parameter, program
| must be able to setup -ISIG not to receive SIGINT by Ctrl-C like
| followings:
| 
|       el_set(el, EL_SETTY, "-d", "-isig", NULL);
| 
| but this doesn't work.
| 
| In tty_rawmode() of lib/libedit/tty.c, the library seems to skip
| applying the clear/set flag bits from "EL_SETTY" if the current
| termios flags is not changed from cached flags.

While I like the refactoring of all tis duplicated code, the removal
of the conditional setting is undesirable. It is meant to prevent the
user for altering the state of the tty from a 3rd party. Consider using
the editor in the shell (which is used in /bin/sh). vi crashes and leaves
the tty in non-canonical, no echo mode. With your change, the changes
from vi get immediately reflected in the editor. What we want instead,
is to recognize the settings from setty as valid, and reflect those
unconditionally. Perhaps that code is broken.

christos