Re: kern/36150 (vnlock deadlock on nbftp due to layerfs and LFS interaction)

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR kern/36150; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/36150 (vnlock deadlock on nbftp due to layerfs and LFS
 interaction)
Date: Sun, 13 Jul 2014 01:18:42 +0000

 On Sat, Jul 12, 2014 at 07:45:00PM +0000, J. Hannken-Illjes wrote:
  >  Some remarks:
  >  
  >  - A long time ago lfs_putpages() DID unlock/relock the vnode lock.
  >    Current lfs has a diagnostic block on VOP_ISLOCKED() but will
  >    not unlock/relock.  Not sure if this was the only unlock.
 
 I found no others, including inside other functions. I might have
 missed one, but it sounds like more likely not.
 
  >  - This PR starts with "thread 1 calls getnewvnode(), which chooses
  >    an nullfs REG vnode to recycle."  Getnewvnode does not recycle
  >    vnodes for a long time -- it always allocates a fresh one.
 
 Oops, I completely overlooked this...
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost