Re: bin/49005: [patch] t_truncate: use /etc/motd instead of /usr/bin/fpr

[Garrett Cooper <yaneurabeya%gmail.com@localhost>]

The following reply was made to PR bin/49005; it has been noted by GNATS.

From: Garrett Cooper <yaneurabeya%gmail.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost
Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of /usr/bin/fpr
Date: Thu, 23 Oct 2014 22:22:42 -0700

 --Apple-Mail=_7B7B5186-365F-4402-886D-C9A915C9667F
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=windows-1252
 
 On Jul 17, 2014, at 12:20, Garrett Cooper <yaneurabeya%gmail.com@localhost> wrote:
 
 > The following reply was made to PR bin/49005; it has been noted by =
 GNATS.
 >=20
 > From: Garrett Cooper <yaneurabeya%gmail.com@localhost>
 > To: "gnats-bugs%NetBSD.org@localhost" <gnats-bugs%netbsd.org@localhost>
 > Cc: "gnats-admin%netbsd.org@localhost" <gnats-admin%netbsd.org@localhost>,=20
 > 	"netbsd-bugs%netbsd.org@localhost" <netbsd-bugs%netbsd.org@localhost>
 > Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of =
 /usr/bin/fpr
 > Date: Thu, 17 Jul 2014 12:19:42 -0700
 >=20
 > On Thu, Jul 17, 2014 at 12:19 PM, Garrett Cooper =
 <yaneurabeya%gmail.com@localhost> wrote:
 >> On Thu, Jul 17, 2014 at 2:10 AM, David Holland =
 <dholland-bugs%netbsd.org@localhost> wrote:
 >>> The following reply was made to PR bin/49005; it has been noted by =
 GNATS.
 >>>=20
 >>> From: David Holland <dholland-bugs%netbsd.org@localhost>
 >>> To: gnats-bugs%NetBSD.org@localhost
 >>> Cc:
 >>> Subject: Re: bin/49005: [patch] t_truncate: use /etc/motd instead of
 >>> /usr/bin/fpr
 >>> Date: Thu, 17 Jul 2014 09:05:40 +0000
 >>>=20
 >>> On Thu, Jul 17, 2014 at 05:40:00AM +0000, yaneurabeya%gmail.com@localhost =
 wrote:
 >>>>> Description:
 >>>> FreeBSD doesn't have /usr/bin/fpr, but it does have /etc/motd, so =
 the testcase should be changed to use /etc/motd.
 >>>=20
 >>> /usr/bin/fpr was chosen on the grounds that it's expendable if
 >>> something goes wrong and it gets truncated. The motd isn't.
 >>=20
 >>    Ah, ok. It might be better to install a file into the source
 >=20
 > source -> tests
 >=20
 >> directory that's owned by root and 0644, then try and truncate it so
 >> the test is more portable and doesn't accidentally hose a utility or
 >> other file that it shouldn't as that's the purpose of the testcase =
 (to
 >> test EACESS). Does that sound like a good approach?
 
 Here=92s a better approach: =
 https://svnweb.freebsd.org/base?view=3Drevision&revision=3D273533 ; =
 here=92s the build target I=92ll be adding to =
 lib/libc/tests/sys/Makefile to generate the file:
 
 > FILESGROUPS=3D            FILES truncate_test_FILES
 >
 > truncate_test_FILES=3D    truncate_test.root_owned
 > truncate_test_FILESDIR=3D ${TESTSDIR}
 > truncate_test_FILESMODE=3D 0600
 > truncate_test_FILESOWNER=3D root
 > truncate_test_FILESGRP=3D wheel
 >
 > CLEANFILES=3D     truncate_test.root_owned
 > truncate_test.root_owned:
 > 	dd if=3D/dev/null bs=3D1 count=3D1 of=3D${.TARGET}
 
 Cheers!
 
 --Apple-Mail=_7B7B5186-365F-4402-886D-C9A915C9667F
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename=signature.asc
 Content-Type: application/pgp-signature;
 	name=signature.asc
 Content-Description: Message signed with OpenPGP using GPGMail
 
 -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org
 
 iQEcBAEBCgAGBQJUSeIiAAoJEMZr5QU6S73eMHwH/RXDnurQL4Y7xKBgbFZi2H7r
 YyWve9IL3UGye7GYmk/FfR4baFwiDIVelbnIktAzSd9uOPpHWX2+OHRMOjQ+gyFn
 sXen6+PI2EuwYe9sjCV8FpaF8UZTxSnuuM+mP7ZvSmNPvq+fqDm4fuxrgJ4KmE1g
 7jmGlB5FwulxCdETTIl6yV73tERSRCPsW7KJVn+69cyYRGFTTDR/fjqF64beQfGW
 PlXgHUYT0pKD9hLtdAgUBYhV0GhLyHGXcfaR784ASs2d1U9PBca99McquHwpYN/3
 xdGvVnY87d7JfPVHTIDpfO1TdkI8T9ee9v402PhyEX3JoXM4JnXCpjtHw6lZrJQ=
 =XE1r
 -----END PGP SIGNATURE-----
 
 --Apple-Mail=_7B7B5186-365F-4402-886D-C9A915C9667F--