kern/49617: posix_fallocate() should be returning an error on failure, without setting errno.

[kirk%ba23.org@localhost]

>Number:         49617
>Category:       kern
>Synopsis:       posix_fallocate() should be returning an error on failure, without setting errno.
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 31 21:45:00 +0000 2015
>Originator:     Kirk Russell
>Release:        netbsd-7/201501202000Z
>Organization:
Bridlewood Software Testers Guild
>Environment:
NetBSD node53 7.0_BETA NetBSD 7.0_BETA (GENERIC.201501202000Z) i386
>Description:
The NetBSD-7 implementation of posix_fallocate() returns -1 and sets errno on failure.  The spec says the call should be returning an error number, without setting the errno.

http://pubs.opengroup.org/onlinepubs/009695399/functions/posix_fallocate.html
>How-To-Repeat:
# atf-run t_posix_fallocate | atf-report
Tests root: /export/wsrc/cvs/src/tests/lib/libc/sys

t_posix_fallocate (1/1): 1 test cases
    ebadf: [0.083528s] Failed: Should return error Invalid argument without setting errno.
[0.137116s]

Failed test cases:
    t_posix_fallocate:ebadf

Summary for 1 test programs:
    0 passed test cases.
    1 failed test cases.
    0 expected failed test cases.
    0 skipped test cases.



--- /dev/null	2015-01-31 21:10:18.000000000 +0000
+++ tests/lib/libc/sys/t_posix_fallocate.c	2015-01-31 21:09:45.000000000 +0000
@@ -0,0 +1,61 @@
+/*-
+ * Copyright 2015, Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ *  * Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ *  * Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *  * Neither the name of Google nor the names of its contributors may
+ *    be used to endorse or promote products derived from this software
+ *    without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <sys/cdefs.h>
+__RCSID("$NetBSD$");
+
+#include <atf-c.h>
+#include <errno.h>
+#include <fcntl.h>
+#include <unistd.h>
+
+ATF_TC_WITHOUT_HEAD(ebadf);
+ATF_TC_BODY(ebadf, tc)
+{
+	int rc, saved;
+
+	errno = 1111;
+	rc = posix_fallocate(-1, 0, 4096);
+	saved = errno;
+	if (rc == -1 && saved != 1111)
+		atf_tc_fail("Should return error %s without setting errno.",
+		    strerror(saved));
+	if (rc != EBADF)
+		atf_tc_fail("returned %s but expected %s.",
+		    strerror(saved), strerror(EBADF));
+	if (saved != 1111)
+		atf_tc_fail("errno should be %d but got changed to %d.",
+		    1111, saved);
+}
+
+ATF_TP_ADD_TCS(tp)
+{
+	ATF_TP_ADD_TC(tp, ebadf);
+	return atf_no_error();
+}

>Fix: