Re: PR/49328 CVS commit: src/sys/dev/pci/ixgbe

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR kern/49328; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: 6bone%6bone.informatik.uni-leipzig.de@localhost, gnats-bugs%NetBSD.org@localhost
Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
	netbsd-bugs%netbsd.org@localhost
Subject: Re: PR/49328 CVS commit: src/sys/dev/pci/ixgbe
Date: Sun, 1 Feb 2015 11:30:57 -0500

 On Feb 1,  5:18pm, 6bone%6bone.informatik.uni-leipzig.de@localhost (6bone%6bone.informatik.uni-leipzig.de@localhost) wrote:
 -- Subject: Re: PR/49328 CVS commit: src/sys/dev/pci/ixgbe
 
 | On Fri, 30 Jan 2015, Christos Zoulas wrote:
 | 
 | > Add this to it:
 | >
 | > christos
 | >
 | > Index: uvm_map.c
 | 
 | The problem is not solved. The crash dump is slightly different from the 
 | last one.
 
 Yes, and my plan is to first fix the NOSLEEP allocation issues and then
 fix the driver so it does not do the deallocation/allocation needlessly.
 Here's the next patch for the first target...
 
 Index: uvm_map.c
 ===================================================================
 RCS file: /cvsroot/src/sys/uvm/uvm_map.c,v
 retrieving revision 1.332
 diff -u -u -r1.332 uvm_map.c
 --- uvm_map.c	23 Jan 2015 16:13:53 -0000	1.332
 +++ uvm_map.c	1 Feb 2015 16:29:46 -0000
 @@ -1182,8 +1182,10 @@
  	 * If the kernel pmap can't map the requested space,
  	 * then allocate more resources for it.
  	 */
 -	if (map == kernel_map && uvm_maxkaddr < (start + size))
 -		uvm_maxkaddr = pmap_growkernel(start + size);
 +	if (map == kernel_map && uvm_maxkaddr < (start + size)) {
 +		if (flags & UVM_FLAG_NOWAIT == 0)
 +			uvm_maxkaddr = pmap_growkernel(start + size);
 +	}
  #endif
  
  	UVMMAP_EVCNT_INCR(map_call);