Re: kern/49657: bge watchdog timeout on HP ML110G6

[tsugutomo.enami%jp.sony.com@localhost]

The following reply was made to PR kern/49657; it has been noted by GNATS.

From: tsugutomo.enami%jp.sony.com@localhost
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/49657: bge watchdog timeout on HP ML110G6
Date: Tue, 17 Feb 2015 15:48:30 +0900

 > The bge(4) on HP ML110G6 sometimes hang and watchdog timer fires.  It
 > worked with NetBSD-5 though.  With -current, kernel build from the
 > source as of 2013/03/16 was OK but 2013/03/18 is not OK.
 
 It looks like the cause of watchdog timeout is newly added
 bge_asf_driver_up() call in bge_tick() in rev. 1.216 (see cited diff
 below).  If I comment out the line, no watchdog timeout occurs.
 
 I guess some locking is necessary.  Linux's tg3.c has tp->lock.
 
 enami.
 
 | diff -u -p -r1.215 -r1.216
 | --- if_bge.c	14 Mar 2013 18:49:20 -0000	1.215
 | +++ if_bge.c	17 Mar 2013 04:06:39 -0000	1.216
 
 	:
 
 | @@ -3855,6 +4393,8 @@ bge_tick(void *xsc)
 |  			mii_tick(mii);
 |  	}
 |  
 | +	bge_asf_driver_up(sc);
 | +
 |  	callout_reset(&sc->bge_timeout, hz, bge_tick, sc);
 |  
 |  	splx(s);