Re: lib/49745: tests/include/sys/t_bitops: improvement

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR lib/49745; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: gnats-bugs%NetBSD.org@localhost, lib-bug-people%netbsd.org@localhost, 
	gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, isaki%pastel-flower.jp@localhost
Cc: 
Subject: Re: lib/49745: tests/include/sys/t_bitops: improvement
Date: Sun, 15 Mar 2015 10:32:48 -0400

 On Mar 15,  8:10am, isaki%pastel-flower.jp@localhost (Tetsuya Isaki) wrote:
 -- Subject: Re: lib/49745: tests/include/sys/t_bitops: improvement
 
 | The following reply was made to PR lib/49745; it has been noted by GNATS.
 | 
 | From: Tetsuya Isaki <isaki%pastel-flower.jp@localhost>
 | To: gnats-bugs%NetBSD.org@localhost
 | Cc: lib-bug-people%netbsd.org@localhost,
 | 	gnats-admin%netbsd.org@localhost,
 | 	netbsd-bugs%netbsd.org@localhost, christos%zoulas.com@localhost
 | Subject: Re: lib/49745: tests/include/sys/t_bitops: improvement
 | Date: Sun, 15 Mar 2015 17:08:36 +0900
 | 
 |  At Sat, 14 Mar 2015 14:20:00 +0000 (UTC),
 |  Christos Zoulas wrote:
 |  >  | >Description:
 |  >  | The current ilog2()'s implementation consists of 32bit variable
 |  >  | part, 64bit variable part and constant part.  But 'ilog2_basic'
 |  >  | test checks only 64bit variable.  32bit variable and constant
 |  >  | were not checked.
 |  :
 |  >  I would prefer if you put the constants in an array and loop instead
 |  >  of inlining it.
 |  
 |  It can not be changed to loop because it tests
 |  __builtin_constant_p() part of ilog2().  If all these inline tests
 |  passed, ATF_TC_BODY(ilog2_const, tc) is compiled into
 
 Ah, ok. Please put a comment to that effect.
 
 Thanks,
 
 christos