Re: lib/49990: libc++ fails to build with g++ 5.1 due to the following types of errors:

[Dave Huang <khym%azeotrope.org@localhost>]

On Jun 23, 2015, at 7:55, Martin Husemann <martin%duskware.de@localhost> wrote:
> The line numbers reported for the errors do not make any sense to me,
> if I look at those lines in exception.cc.
> 
> I find this forward declaration:
> 
>     676 #if __GNUC__ > 3 && __GNUC_MINOR__ > 2 
>     677 extern "C" void *__cxa_begin_catch(void *e) throw();
>     678 #else
>     679 extern "C" void *__cxa_begin_catch(void *e);
>     680 #endif  
> 
> and this definition:
> 
>    1192 #if __GNUC__ > 3 && __GNUC_MINOR__ > 2
>    1193 extern "C" void *__cxa_begin_catch(void *e) throw()
>    1194 #else           
>    1195 extern "C" void *__cxa_begin_catch(void *e)
>    1196 #endif          
>    1197 {       
> 
> which seem to be consistent to me. I also don't see any changes to the
> predefined __GNUC__ or __GNUC_MINOR__ macros.

While they are consistent, I'm not sure what the intent is. If it's 
supposed to be checking for gcc > 3.2, I'm pretty sure that's not the 
way to do it.
-- 
Name: Dave Huang         |  Mammal, mammal / their names are called /
INet: khym%azeotrope.org@localhost |  they raise a paw / the bat, the cat /
FurryMUCK: Dahan         |  dolphin and dog / koala bear and hog -- TMBG
Dahan: Hani G Y+C 39 Y++ L+++ W- C++ T++ A+ E+ S++ V++ F- Q+++ P+ B+ PA+ PL++