Re: kern/50070: fsck OK but mount: incorrect super block

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR kern/50070; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: "J. Hannken-Illjes" <hannken%eis.cs.tu-bs.de@localhost>,
	Maxime Villard <maxv%NetBSD.org@localhost>
Subject: Re: kern/50070: fsck OK but mount: incorrect super block
Date: Thu, 22 Oct 2015 09:37:43 +0200

 J. Hannken-Illjes wrote:
 
 >  This cgsize test from ffs_superblock_validate() is wrong.  Newfs aligns
 >  fs_cgsize to fragment size:
 >  
 >  	sblock.fs_cgsize = ffs_fragroundup(&sblock, CGSIZE(&sblock));
 >  
 >  All we should test here is
 >  
 >  	fs->fs_cgsize >= sizeof(struct cg)
 >  	fs->fs_cgsize <= fs->fs_bsize
 
 So can we fix it, please?
 
 Martin