Re: kern/50395: Loss of characters in serial port communication between gdb and kgdb_stub

[Vicente Chaves de Melo <vchaves%ymail.com@localhost>]

The following reply was made to PR kern/50395; it has been noted by GNATS.

From: Vicente Chaves de Melo <vchaves%ymail.com@localhost>
To: Christos Zoulas <christos%zoulas.com@localhost>, gnats-bugs%NetBSD.org@localhost,
 kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/50395: Loss of characters in serial port communication
 between gdb and kgdb_stub
Date: Sun, 8 Nov 2015 00:20:47 -0200

 On 02/11/2015 15:43, Christos Zoulas wrote:
 > On Nov 2,  5:35pm, vchaves%ymail.com@localhost (Vicente Chaves de Melo) wrote:
 > -- Subject: Re: kern/50395: Loss of characters in serial port communication b
 >
 > | The following reply was made to PR kern/50395; it has been noted by GNATS.
 > |
 > | From: Vicente Chaves de Melo <vchaves%ymail.com@localhost>
 > | To: gnats-bugs%NetBSD.org@localhost
 > | Cc:
 > | Subject: Re: kern/50395: Loss of characters in serial port communication
 > |  between gdb and kgdb_stub
 > | Date: Mon, 2 Nov 2015 15:29:55 -0200
 > |
 > |  Hey Christos,
 > |  about fix in function comshutdown () I stand by my suggestion.
 > |
 > |  I believe that changing the flag IER_ERXRDY to IER_ERLS we will obtain
 > |  the following two benefits
 > |
 > |  1) there will be no more interruptions generated for this COM after the
 > |  shutdown. That would seem to be the intent of this part of the code.
 > |
 > |  2) Allow the user to enter the debugger even after the shutdown, sending
 > |  a BREAK on the serial port.
 > |
 > |  I also believe that it wasn't such a wise idea to mix the com_shutdown
 > |  subject in the same PR problem with kgdb.
 > |  Wouldn't it be better if I open another PR to deal with this matter?
 >
 > Sure, I agree with the current changes. If you want, please open another
 > PR to fix the shutdown issue in a better way.
 >
 > Thanks,
 >
 > christos
 Hey Christos,
 I noticed that you already applied the fixes, so I don't think it's 
 necessary to open a new PR.
 I believe that this PR can be close.
 Thank you very much
 Vicente.