Re: kern/50898: src/sys/dev/pci/n8/common/api/n8_rsa.c: pointless call to memset ?

To: dcb314%hotmail.com@localhost
Subject: Re: kern/50898: src/sys/dev/pci/n8/common/api/n8_rsa.c: pointless call to memset ?
From: Timo Buhrmester <fstd.lkml%gmail.com@localhost>
Date: Sun, 6 Mar 2016 18:36:47 +0100

> [src/sys/dev/pci/n8/common/api/n8_rsa.c:1075]
>       memset(vAddr, 0, nBytes);
>       memset(vAddr, 0x0, padding);
> 
> The second one looks redundant to me.
Only if padding <= nBytes, otherwise first one would be the redundant,
statement.  But yes, definitely looks bogus.

Maybe something like ``memset(vAddr + nBytes, 0, padding)'' was intended?
What are real-world values of nBytes and padding?

References:
- kern/50898: src/sys/dev/pci/n8/common/api/n8_rsa.c: pointless call to memset ?
  - From: dcb314

Prev by Date: kern/50899: src/sys/netinet/sctputil.c:857: sloppy call to memset ?
Next by Date: kern/50900: src/sys/rump/librump/rumpvfs/rumpfs.c:936: clumsy call to memset ?
Previous by Thread: kern/50898: src/sys/dev/pci/n8/common/api/n8_rsa.c: pointless call to memset ?
Next by Thread: kern/50899: src/sys/netinet/sctputil.c:857: sloppy call to memset ?
Indexes:

Home | Main Index | Thread Index | Old Index